This repository was archived by the owner on Oct 13, 2023. It is now read-only.
[18.06] disable containerd CRI plugin#29
Merged
Conversation
Docker 18.06 does not have a configuration option to disable the CRI plugin, and this plugin is not very useful if containerd is not running standalone. This patch disables the plugin if containerd is running as child-process of dockerd. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
andrewhsu
approved these changes
Aug 7, 2018
andrewhsu
left a comment
There was a problem hiding this comment.
LGTM wrt not having a CRI plugin listening on a port
|
Still present on latest CoreOS with 18.06.1-ce: Any idea? |
Member
Author
|
^^ answered here; containerd/containerd#2483 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of moby#37519 fr 18.06, but without configuration option.
fixes moby#37507 for 18.06
Docker 18.06 does not have a configuration option to disable the CRI plugin, and this plugin is not very useful if containerd is not running standalone.
This patch disables the plugin if containerd is running as child-process of dockerd.
- How to verify it
dockerd &)- Description for the changelog